Skip to content

Commit

Permalink
Merge pull request #2079 from github/aeisenberg/artifact-storage
Browse files Browse the repository at this point in the history
Add a retention period of 7 days
  • Loading branch information
aeisenberg authored Jan 10, 2024
2 parents 3b54300 + f5a8218 commit cd94990
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the

## [UNRELEASED]

No user facing changes.
- Change the retention period for uploaded debug artifacts to 7 days. Previously, this was whatever the repository default was. [#2079](https://github.com/github/codeql-action/pull/2079)

## 3.23.0 - 08 Jan 2024

Expand Down
6 changes: 5 additions & 1 deletion lib/debug-artifacts.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/debug-artifacts.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion src/debug-artifacts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,11 @@ export async function uploadDebugArtifacts(
sanitizeArifactName(`${artifactName}${suffix}`),
toUpload.map((file) => path.normalize(file)),
path.normalize(rootDir),
{ continueOnError: true },
{
continueOnError: true,
// ensure we don't keep the debug artifacts around for too long since they can be large.
retentionDays: 7,
},
);
}

Expand Down

0 comments on commit cd94990

Please sign in to comment.