Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix direct round view #2954

Merged
merged 7 commits into from
Feb 16, 2024
Merged

fix direct round view #2954

merged 7 commits into from
Feb 16, 2024

Conversation

boudra
Copy link
Contributor

@boudra boudra commented Feb 16, 2024 •
edited
Loading

Fixes: #issue

Description

this is temporary, I will sort this out in my PR to fetch round from indexer

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@boudra boudra requested review from a team as code owners February 16, 2024 15:36
@vercel Vercel
Copy link

vercel bot commented Feb 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 4:30pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 1 unresolved Feb 16, 2024 4:30pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 4:30pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 4:30pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 4:30pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 4:30pm

bhargavaparoksham
bhargavaparoksham approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@bhargavaparoksham bhargavaparoksham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some checks have failed. Other than that looks good.

@gitstream-cm gitStream.cm
Copy link

gitstream-cm bot commented Feb 16, 2024

This PR is 71.42857142857143% new code.

@boudra boudra merged commit a35db33 into main Feb 16, 2024
18 of 19 checks passed
@boudra boudra deleted the fix-direct-round-view branch February 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravityblast gravityblast gravityblast approved these changes

@bhargavaparoksham bhargavaparoksham bhargavaparoksham approved these changes

Assignees
No one assigned
Labels
1 min review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boudra @gravityblast @bhargavaparoksham