Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Programs from Indexer #2946

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Load Programs from Indexer #2946

merged 4 commits into from
Feb 16, 2024

Conversation

boudra
Copy link
Contributor

@boudra boudra commented Feb 15, 2024

subtask of #2870

Description

this completes the task to load programs from the indexer and simplifies some things:

  • Create program advises user to create a project on Builder (temporary solution until we define the flow)
  • Implement loading a single program from the indexer
  • Fix and simplify the program types in the data layer

What to test

  • Create a program in Allo V2 doesn't work, you have to use Builder in Allo V2 mode
  • Create a program still works for Allo V1
  • In the manager homepage, programs should be loaded for Allo V1 and V2
  • You should be able to click and view the rounds of a single program

Video of round creation: https://www.loom.com/share/ebaec99b1ed0485dae5ef5ec1bc9bca4

Checklist

This PR:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@boudra boudra requested review from a team as code owners February 15, 2024 13:00
Copy link

sentry-io bot commented Feb 15, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/round-manager/src/features/api/program.ts

Function Unhandled Issue
listPrograms Error: Unable to fetch programs listPrograms(feat...
Event Count: 14 Affected Users: 4
listPrograms TypeError: undefined is not an object (evaluating 'i.data.programs') listPrograms(f...
Event Count: 7 Affected Users: 1
listPrograms Error: GraphQL Error (Code: 502): {"response":{"error":"","status":502,"headers":{"map":{"content-length... ...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 3:13pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 3:13pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 3:13pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 3:13pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 3:13pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 3:13pm

Copy link

gitstream-cm bot commented Feb 15, 2024

🥷 Code experts: bhargavaparoksham, codenamejason

bhargavaparoksham, codenamejason have most 👩‍💻 activity in the files.
bhargavaparoksham, codenamejason have most 🧠 knowledge in the files.

See details

packages/data-layer/src/data-layer.ts

Activity based on git-commit:

bhargavaparoksham codenamejason
FEB 93 additions & 10 deletions 184 additions & 9 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 28%
bhargavaparoksham: 13%

packages/data-layer/src/data.types.ts

Activity based on git-commit:

bhargavaparoksham codenamejason
FEB 26 additions & 5 deletions 132 additions & 0 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 28%
bhargavaparoksham: 4%

packages/data-layer/src/queries.ts

Activity based on git-commit:

bhargavaparoksham codenamejason
FEB 68 additions & 5 deletions 153 additions & 0 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
codenamejason: 44%
bhargavaparoksham: 18%

packages/round-manager/src/context/program/ReadProgramContext.tsx

Activity based on git-commit:

bhargavaparoksham codenamejason
FEB 10 additions & 2 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
bhargavaparoksham: 5%

packages/round-manager/src/features/api/__tests__/program.test.ts

Activity based on git-commit:

bhargavaparoksham codenamejason
FEB 29 additions & 32 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
bhargavaparoksham: 29%

packages/round-manager/src/features/api/program.ts

Activity based on git-commit:

bhargavaparoksham codenamejason
FEB 21 additions & 34 deletions
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
bhargavaparoksham: 11%

packages/round-manager/src/features/program/CreateProgramPage.tsx

Activity based on git-commit:

bhargavaparoksham codenamejason
FEB
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
bhargavaparoksham: 4%

packages/round-manager/src/features/round/__tests__/CreateRoundPage.test.tsx

Activity based on git-commit:

bhargavaparoksham codenamejason
FEB
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Feb 15, 2024

This PR is 52.95950155763239% new code.

@boudra boudra merged commit 7f2292b into main Feb 16, 2024
20 checks passed
@boudra boudra deleted the load-programs branch February 16, 2024 09:46
boudra added a commit that referenced this pull request Feb 16, 2024
Copy link

sentry-io bot commented Feb 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: GraphQL Error (Code: 502): {"response":{"error":"","status":502,"headers":{"map":{"content-length... DataLayer.getProgramByIdAndUser(data-layer/src/... View Issue
  • ‼️ Error: GraphQL Error (Code: 502): {"response":{"error":"<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Tr... DataLayer.getProgramById(data-layer/src/data-la... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants