Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing checks for '/' in branch names by checks for "origin/" #106

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

johanneslerch
Copy link

The problem described in #101 seems to be caused by several locations checking if a branch name contains a forward slash '/' to identify remote branches. However, this over-approximating check makes it impossible to illustrate, e.g., a git flow using branch names like "feature/foobar".
In my changes I replaced the check for '/' by a check for "origin/", which seems to solve the problem. However, this solution will again fail as soon as a remote is not called origin, so this is also not the best solution.
It can be tested already on the fork: https://johanneslerch.github.io/visualizing-git/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants