Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 1:1 Mentorship bug #414

Closed
wants to merge 3 commits into from
Closed

Conversation

Meetjain1
Copy link
Contributor

closes https://github.com/GSSoC24/being-an-GSSoc24/issues/202
Now the 1:1 Mentorsship button will only appear if there is a topmate link present in any profile and will auto disappear when user moves to other page or other profile , Also It will take user to that particular person profile link only when it click on 1:1 Mentorship button

2024-09-15-21-56-20.mp4

@Meetjain1
Copy link
Contributor Author

Meetjain1 commented Sep 15, 2024

@Hemu21 @MastanSayyad

@vansh-codes
Copy link
Contributor

vansh-codes commented Sep 15, 2024

Hey @Meetjain1
now the topmate thing wont be coming as a popup right? Now it will redirect the user to the respective team members topmate page instead of coming up as a popup on the gssoc page itself.. now the user will be redirected to the topmate mentorship booking tab, right??

I guess the purpose was to fix the problem with the script and not changing the script to be as a button 😅

@sanjay-kv
Copy link
Member

closes GSSoC24/being-an-GSSoc24#202 Now the 1:1 Mentorsship button will only appear if there is a topmate link present in any profile and will auto disappear when user moves to other page or other profile , Also It will take user to that particular person profile link only when it click on 1:1 Mentorship button

2024-09-15-21-56-20.mp4

I just saw this, there is a catch . we are not suppose to take anyone out of gssoc website.
It should be pop up only for that reason im closing this PR.

@sanjay-kv sanjay-kv closed this Sep 16, 2024
@Meetjain1
Copy link
Contributor Author

closes GSSoC24/being-an-GSSoc24#202 Now the 1:1 Mentorsship button will only appear if there is a topmate link present in any profile and will auto disappear when user moves to other page or other profile , Also It will take user to that particular person profile link only when it click on 1:1 Mentorship button
2024-09-15-21-56-20.mp4

I just saw this, there is a catch . we are not suppose to take anyone out of gssoc website. It should be pop up only for that reason im closing this PR.

Its a popup button only which I dont added , I just fixed the bug that is it should not appear on other pages . I suggested to remove this button completely in the issue https://github.com/GSSoC24/being-an-GSSoc24/issues/202 closing this pr will cause the button bug to presist , We should remove this button completely or we should place it as I did in this PR let me know what to do @sanjay-kv

@vansh-codes
Copy link
Contributor

@Meetjain1 hi
Can you share one video where you click that button and we see what happens when it's clicked
It would be clear for everyone to understand your changes

@Meetjain1
Copy link
Contributor Author

@Meetjain1 hi Can you share one video where you click that button and we see what happens when it's clicked It would be clear for everyone to understand your changes

Hi @vansh-codes as I mentioned it will redirect to 1:1 mentorship of that particular person profile

@vansh-codes
Copy link
Contributor

That's what we don't want bro, we don't want to take the user out of GSSoC website, we want it to appear as a popup on the website itself as it is now

@Meetjain1
Copy link
Contributor Author

That's what we don't want bro, we don't want to take the user out of GSSoC website, we want it to appear as a popup on the website itself as it is now

Ohk , Thanks fixing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants