-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed 1:1 Mentorship bug #414
Conversation
Hey @Meetjain1 I guess the purpose was to fix the problem with the script and not changing the script to be as a button 😅 |
I just saw this, there is a catch . we are not suppose to take anyone out of gssoc website. |
Its a popup button only which I dont added , I just fixed the bug that is it should not appear on other pages . I suggested to remove this button completely in the issue https://github.com/GSSoC24/being-an-GSSoc24/issues/202 closing this pr will cause the button bug to presist , We should remove this button completely or we should place it as I did in this PR let me know what to do @sanjay-kv |
@Meetjain1 hi |
Hi @vansh-codes as I mentioned it will redirect to 1:1 mentorship of that particular person profile |
That's what we don't want bro, we don't want to take the user out of GSSoC website, we want it to appear as a popup on the website itself as it is now |
Ohk , Thanks fixing it |
closes https://github.com/GSSoC24/being-an-GSSoc24/issues/202
Now the 1:1 Mentorsship button will only appear if there is a topmate link present in any profile and will auto disappear when user moves to other page or other profile , Also It will take user to that particular person profile link only when it click on 1:1 Mentorship button
2024-09-15-21-56-20.mp4