Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): added search tags to projects #135

Merged
merged 3 commits into from
Jul 5, 2023
Merged

feat(search): added search tags to projects #135

merged 3 commits into from
Jul 5, 2023

Conversation

shobhitexe
Copy link
Contributor

Closes #133

Here's what I did:

  • added 15 tags to make searching and sorting easier.
  • ranked the tags based on how popular they are.

To do this, I gathered project data from ProjectData.js and checked how often each tag appeared. Then, I selected the top 15 tags based on their frequency. I also kept a complete list of all the data in case we need it later on.

2023-07-01.12-28-02.mp4

Copy link
Member

@Suvraneel Suvraneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@shobhitexe Functionality looks good. Changes:

  1. Limit the no. of rows to two... Take more width if needed
  2. add a rounded effect to SearchTags border for uniformity with all the other components

@shobhitexe shobhitexe requested a review from Suvraneel July 4, 2023 06:01
@Suvraneel
Copy link
Member

Suvraneel commented Jul 5, 2023

@shobhitexe LGTM ❤️ :octocat:

@Suvraneel Suvraneel merged commit 6dd3416 into girlscript:main Jul 5, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add tags for better search
2 participants