Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure libphonenumber-for-php-lite to be replaced by this package #625

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Configure libphonenumber-for-php-lite to be replaced by this package #625

merged 1 commit into from
Apr 8, 2024

Conversation

Propaganistas
Copy link
Contributor

libphonenumber-for-php-lite is currently configured to conflict with libphonenumber-for-php. This leads to both packages not being able to be installed simultaneously, which is of course intended behavior.

However, this breaks the dependency chain for packages requiring either of them.

Imagine the following scenario:

  • project dependencies

    • libphonenumber-for-php
    • some-package
  • some-package dependencies

    • libphonenumber-for-php-lite

This will fail because of the conflict configuration.

It'd be better to:

  1. Configure libphonenumber-for-php to replace libphonenumber-for-php-lite
  2. Remove the conflict configuration from libphonenumber-for-php-lite

replace means: this package provides everything the other package has as well in the very same namespace (and probably more).

This way, libphonenumber-for-php-lite gets installed when it's the only package requested from the family. But whenever any dependency (either project or package) requires libphonenumber-for-php, only that gets installed without conflict failures 'cause everything lite has to offer is defined to be also available in the original.

@giggsey
Copy link
Owner

giggsey commented Apr 8, 2024

Thanks, that makes sense.

You've just missed Google's two weekly release, so it'll be a little while until there is a new tag

@giggsey giggsey disabled auto-merge April 8, 2024 07:05
@giggsey giggsey merged commit 3cf428e into giggsey:master Apr 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants