Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix string parameter type hinted as integer #612

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix string parameter type hinted as integer #612

merged 1 commit into from
Jan 8, 2024

Commits on Jan 8, 2024

  1. Fix string parameter type hinted as integer 

    extractPossibleNumber in PhoneNumberUtil.php wants a string for the $number parameter as also stated in the method's documention (since a string with special charactars like '-' cannot be an integer), but was type hinted as an integer causing PHP stan errors.
    @Finidi-Schoonhoven
    Finidi-Schoonhoven committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    8d9277e View commit details
    Browse the repository at this point in the history