Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: don't invalidate grid rows more than once #1265

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

ghiscoding
Copy link
Owner

  • see this Slickgrid-Universal comment for more details

Copy link

stackblitz bot commented Sep 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 21.56%. Comparing base (ec2a86e) to head (ec31714).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...slickgrid/src/custom-elements/aurelia-slickgrid.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
- Coverage   21.63%   21.56%   -0.06%     
==========================================
  Files           8        8              
  Lines         934      937       +3     
  Branches      346      324      -22     
==========================================
  Hits          202      202              
- Misses        732      735       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 740995c into master Sep 14, 2024
3 of 4 checks passed
@ghiscoding ghiscoding deleted the perf/grouping-rows-changed branch September 14, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant