rename after -> until

gh123man · Jul 12, 2023 · 2473bf8 · 2473bf8
1 parent c87cb00
commit 2473bf8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -68,7 +68,7 @@ Set the absolute offset to a fixed value:
 It may be desirable for `shouldLoadMore` to be called whenever the user scrolls - even if the scroll view content didn't change. You can change this behavior with `waitForHeightChange`: 
 ```swift 
 .shouldLoadMore(waitForHeightChange: .never) { 
-    // Will be called regardless of if the height changed from a previous update
+    // Will be called regardless of if the content height changed from a previous update
 }
 ```
 
@@ -79,7 +79,7 @@ It may be desirable for `shouldLoadMore` to be called whenever the user scrolls
 ```
 
 ```swift 
-.shouldLoadMore(waitForHeightChange: .after(2)) { 
+.shouldLoadMore(waitForHeightChange: .until(2)) { 
     // Will only be called if the content height changed since last time or after 2 seconds of no change
 }
 ```

diff --git a/Sources/ScrollViewLoader/ScrollViewLoader.swift b/Sources/ScrollViewLoader/ScrollViewLoader.swift
@@ -5,7 +5,7 @@ import Introspect
 
 public enum HeightChangeConfig {
     case always
-    case after(TimeInterval)
+    case until(TimeInterval)
     case never
 }
 
@@ -16,7 +16,7 @@ public enum OffsetTrigger {
 
 extension View {
     public func shouldLoadMore(bottomDistance offsetTrigger: OffsetTrigger = .relative(0.5),
-                               waitForHeightChange: HeightChangeConfig = .after(2),
+                               waitForHeightChange: HeightChangeConfig = .until(2),
                                shouldLoadMore: @escaping () async -> ()) -> some View  {
         return DelegateHolder(offsetNotifier: ScrollOffsetNotifier(offsetTrigger: offsetTrigger,
                                                                    waitForHeightChange: waitForHeightChange,
@@ -25,7 +25,7 @@ extension View {
     }
 
     public func shouldLoadMore(bottomDistance offsetTrigger: OffsetTrigger = .relative(0.5),
-                               waitForHeightChange: HeightChangeConfig = .after(2),
+                               waitForHeightChange: HeightChangeConfig = .until(2),
                                shouldLoadMore: @escaping (_ done: @escaping () -> ()) -> ()) -> some View  {
         return DelegateHolder(offsetNotifier: ScrollOffsetNotifier(offsetTrigger: offsetTrigger,
                                                                    waitForHeightChange: waitForHeightChange,
@@ -104,7 +104,7 @@ class ScrollOffsetNotifier: NSObject, UIScrollViewDelegate, ObservableObject {
         switch waitForHeightChange {
         case .always:
             heightChanged = oldContentHeight != scrollView.contentSize.height
-        case .after(let timeInterval):
+        case .until(let timeInterval):
             heightChanged = oldContentHeight != scrollView.contentSize.height
             if !isTimerRunning {
                 isTimerRunning = true