Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usage of a deprecated Node.js version in CI #6301

Merged

Conversation

hamirmahal
Copy link
Contributor

Connections
_Link to the issues addressed by this PR, or dependent PRs in other repositories
Fixes #6300

Description
Describe what problem this is solving, and how it's solved.
.github/workflows/ci.yml uses codecov/codecov-action@v3, which uses a deprecated Node.js version, and this pull request updates it so that it no longer does.

Testing
Explain how this change is tested.
I ran cargo xtask test locally.

Checklist

  • Run cargo fmt.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@hamirmahal hamirmahal requested a review from a team as a code owner September 20, 2024 18:08
@hamirmahal
Copy link
Contributor Author

Full disclosure: cargo xtask test failed locally.

Partial output
        PASS [   1.249s] wgpu-benchmark::bench/root front/shader: spv-in
        PASS [   1.472s] wgpu-benchmark::bench/root front/shader: wgsl-in
        PASS [   1.458s] wgpu-benchmark::bench/root validate/shader: validation
        FAIL [   1.751s] wgpu-examples [Executed Failure: BACKEND] [Vulkan/Intel(R) HD Graphics 530 (SKL GT2)/0] water

--- STDOUT:              wgpu-examples [Executed Failure: BACKEND] [Vulkan/Intel(R) HD Graphics 530 (SKL GT2)/0] water ---

running 1 test
Starting image comparison test with reference image "/home/hamir/wgpu/examples/..//examples/src/water/screenshot.png"
        Mean: 0.000030
        Min Value: 0.000000
              25%: 0.000719
              50%: 0.001685
              75%: 0.003958
              95%: 0.009105
              99%: 0.013194
        Max Value: 0.019263
        Expected Mean (0.000030) to be under expected maximum (0.01): PASS
test [Executed Failure: BACKEND] [Vulkan/Intel(R) HD Graphics 530 (SKL GT2)/0] water ... FAILED

failures:

---- [Executed Failure: BACKEND] [Vulkan/Intel(R) HD Graphics 530 (SKL GT2)/0] water ----
test panicked: examples/src/framework.rs:536:9: test "water" did not behave as expected


failures:
    [Executed Failure: BACKEND] [Vulkan/Intel(R) HD Graphics 530 (SKL GT2)/0] water

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 83 filtered out; finished in 1.73s


--- STDERR:              wgpu-examples [Executed Failure: BACKEND] [Vulkan/Intel(R) HD Graphics 530 (SKL GT2)/0] water ---
[examples/src/framework.rs:629:21] env!("CARGO_MANIFEST_DIR").to_string() + "/../" + params.image_path = "/home/hamir/wgpu/examples/..//examples/src/water/screenshot.png"
[2024-09-20T18:04:45Z ERROR wgpu_test::expectations] Expected to fail due to [FailureReason { kind: Some(ValidationError), message: Some("Hazard WRITE_AFTER_") }], but did not fail
thread '<unnamed>' panicked at tests/src/run.rs:120:9:
examples/src/framework.rs:536:9: test "water" did not behave as expected
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

        PASS [   1.443s] wgpu-examples [Executed] [Gl/Mesa Intel(R) HD Graphics 530 (SKL GT2)/2] boids
        PASS [   1.681s] wgpu-examples [Executed] [Gl/Mesa Intel(R) HD Graphics 530 (SKL GT2)/2] cube-lines
        FAIL [   2.288s] wgpu-examples [Executed Failure: BACKEND] [Vulkan/llvmpipe (LLVM 15.0.7, 256 bits)/1] water

--- STDOUT:              wgpu-examples [Executed Failure: BACKEND] [Vulkan/llvmpipe (LLVM 15.0.7, 256 bits)/1] water ---

running 1 test
Starting image comparison test with reference image "/home/hamir/wgpu/examples/..//examples/src/water/screenshot.png"
        Mean: 0.006310
        Min Value: 0.000000
              25%: 0.016000
              50%: 0.028068
              75%: 0.048141
              95%: 0.051326
              99%: 0.054400
        Max Value: 0.280842
        Expected Mean (0.006310) to be under expected maximum (0.01): PASS
test [Executed Failure: BACKEND] [Vulkan/llvmpipe (LLVM 15.0.7, 256 bits)/1] water ... FAILED

failures:

---- [Executed Failure: BACKEND] [Vulkan/llvmpipe (LLVM 15.0.7, 256 bits)/1] water ----
test panicked: examples/src/framework.rs:536:9: test "water" did not behave as expected


failures:
    [Executed Failure: BACKEND] [Vulkan/llvmpipe (LLVM 15.0.7, 256 bits)/1] water

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 83 filtered out; finished in 2.27s


--- STDERR:              wgpu-examples [Executed Failure: BACKEND] [Vulkan/llvmpipe (LLVM 15.0.7, 256 bits)/1] water ---
[examples/src/framework.rs:629:21] env!("CARGO_MANIFEST_DIR").to_string() + "/../" + params.image_path = "/home/hamir/wgpu/examples/..//examples/src/water/screenshot.png"
[2024-09-20T18:04:46Z ERROR wgpu_test::expectations] Expected to fail due to [FailureReason { kind: Some(ValidationError), message: Some("Hazard WRITE_AFTER_") }], but did not fail
thread '<unnamed>' panicked at tests/src/run.rs:120:9:
examples/src/framework.rs:536:9: test "water" did not behave as expected
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@cwfitzgerald
Copy link
Member

Thanks!

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) September 20, 2024 19:31
@cwfitzgerald cwfitzgerald merged commit 14abdd4 into gfx-rs:trunk Sep 20, 2024
27 checks passed
@hamirmahal hamirmahal deleted the fix/usage-of-a-deprecated-nodejs-version branch September 20, 2024 19:53
@hamirmahal
Copy link
Contributor Author

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI uses codecov/codecov-action@v3, which uses a deprecated Node.js version
2 participants