[d3d12] get num_workgroups builtin working for indirect dispatches
#5730
+1,164
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
teoxoy
force-pushed
the
d3d12-num_workgroups
branch
from
59891d9
to
2599f0f
Compare
teoxoy
force-pushed
the
d3d12-num_workgroups
branch
2 times, most recently
from
a33b80c
to
fed4db1
Compare
teoxoy
force-pushed
the
d3d12-num_workgroups
branch
2 times, most recently
from
8fbc078
to
fb99ea9
Compare
teoxoy
force-pushed
the
d3d12-num_workgroups
branch
2 times, most recently
from
17d83a8
to
164a658
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ErichDonGubler
force-pushed
the
d3d12-num_workgroups
branch
from
164a658
to
849d348
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ErichDonGubler
approved these changes
Sep 4, 2024
ErichDonGubler
force-pushed
the
d3d12-num_workgroups
branch
3 times, most recently
from
976a211
to
0ba0176
Compare
ErichDonGubler
force-pushed
the
d3d12-num_workgroups
branch
from
0ba0176
to
70791c1
Compare
ErichDonGubler
force-pushed
the
d3d12-num_workgroups
branch
from
70791c1
to
8891fff
Compare
ErichDonGubler
force-pushed
the
d3d12-num_workgroups
branch
3 times, most recently
from
c47b597
to
e37496a
Compare
by injecting a compute shader that validates the content of the indirect buffer
This removes the required barrier prior to the validation dispatch.
…index,cmd_signatures}` into new `struct`
ErichDonGubler
force-pushed
the
d3d12-num_workgroups
branch
from
e37496a
to
49e5b2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Depends on #5714.
Follow-up to #1816.
Description
num_workgroupsused to always be0, 0, 0for indirect dispatches; it now works properly.This PR adds the logic needed to update the root constants with the right values for the
num_workgroupsbuiltin.Testing
There is a test.