Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Hotfix: update Cocoa SDK from 8.29.1 to 8.36.0 #4102

Draft
wants to merge 9 commits into
base: hotfix/5.24.3
Choose a base branch
from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Sep 19, 2024

Bumps Cocoa SDK version from 8.29.1 to 8.36.0 for hotfix release 5.24.3.
Also:

Changelog

8.36.0

Features

Fixes

  • Proper redact SR during animation (#4289)

8.35.1

Fixes

  • Crash when reading corrupted envelope (#4297)

8.35.0

Features

  • Expose span baggage API (#4207)

Fixes

  • Fix SIGABRT when modifying scope user (#4274)
  • Crash during SDK initialization due to corrupted envelope (#4291)
    • Reverts #4219 as potential fix

8.34.0

Features

  • Pause replay in session mode when offline (#4264)
  • Add replay quality option for Objective-C (#4267)

Fixes

  • Session replay not redacting buttons and other non UILabel texts (#4277)
  • Rarely reporting too long frame delays (#4278) by fixing a race condition in the frames tracking logic.
  • Crash deserializing empty envelope length>0 (#4281]
  • Guard dereferencing of stack frame pointer in SentryBacktrace (#4268)

8.33.0

Note: Due to a bug (#4280) introduced in this release, we recommend upgrading to 8.35.0 or newer.


This release fixes a bug (#4230) that we introduced with a refactoring (#4101) released in 8.30.1.
This bug caused unhandled/crash events to have the unhandled property and mach info missing, which is required for release health to show events in the unhandled tab. It's essential to mention that this bug doesn't impact release health statistics, such as crash-free session or user rates.

Features

  • Support orientation change for session replay (#4194)
  • Replay for crashes (#4171)
  • Redact web view from replay (#4203)
  • Add beforeCaptureViewHierarchy callback (#4210)
  • Rename session replay errorSampleRate property to onErrorSampleRate (#4218)
  • Add options to redact or ignore view for Replay (#4228)

Fixes

  • Skip UI crumbs when target or sender is nil (#4211)
  • Guard FramesTracker start and stop (#4224)
  • Long-lasting TTID/TTFD spans (#4225). Avoid long TTID spans when the FrameTracker isn't running, which is the case when the app is in the background.
  • Missing mach info for crash reports (#4230)
  • Crash reports not generated on visionOS (#4229)
  • Don’t force cast to NSComparisonPredicate in TERNARY operator (#4232)
  • Fix accessing UI API on bg thread in enrichScope (#4245)
  • EXC_BAD_ACCESS in SentryMetricProfiler (#4242)
  • Missing '#include <sys/_types/_ucontext64.h>' (#4244)
  • Rare flush timeout when called in tight loop (#4257)

Improvements

  • Reduce memory usage of storing envelopes (#4219)
  • Skip enriching scope when nil (#4243)

8.32.0

Features

  • Add reportAccessibilityIdentifier option (#4183)
  • Record dropped spans (#4172)

Fixes

  • Session replay crash when writing the replay (#4186)

Features

  • Collect only unique UIWindow references (#4159)

Deprecated

  • options.enableTracing was deprecated. Use options.tracesSampleRate or options.tracesSampler instead. (#4182)

8.31.1

Fixes

  • Session replay video duration from seconds to milliseconds (#4163)

8.31.0

Features

  • Include the screen names in the session replay (#4126)

Fixes

  • Properly handle invalid value for NSUnderlyingErrorKey (#4144)
  • Session replay in buffer mode not working (#4160)

8.30.1

Fixes

  • UIKitless configurations now produce a module with a different name (#4140)
  • Sentry Replay Serialized Breadcrumbs include level name (#4141)

8.30.0

Features

Fixes

@antonis antonis marked this pull request as draft September 19, 2024 08:50
@antonis antonis marked this pull request as ready for review September 19, 2024 09:25
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 393.35 ms 433.96 ms 40.61 ms
Size 7.15 MiB 8.21 MiB 1.07 MiB

Copy link
Contributor

github-actions bot commented Sep 19, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.09 ms 1236.17 ms 1.08 ms
Size 2.92 MiB 3.63 MiB 733.79 KiB

CHANGELOG.md Outdated Show resolved Hide resolved
@antonis antonis requested a review from kahest September 19, 2024 09:48
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

github-actions bot commented Sep 19, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.42 ms 1235.25 ms 3.83 ms
Size 2.36 MiB 3.07 MiB 726.37 KiB

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 517.20 ms 518.84 ms 1.64 ms
Size 17.73 MiB 19.94 MiB 2.21 MiB

@antonis antonis marked this pull request as draft September 19, 2024 10:40
@antonis
Copy link
Collaborator Author

antonis commented Sep 19, 2024

Adding some notes on the failing CI tests:

  • Build RN 0.73.2 new hermes android production no and Build RN 0.73.2 legacy hermes android production no should be related with the sourceMapString is not a function fix
  • Build legacy ios dev no-frameworks, Build legacy ios production no-frameworks, Build new ios dev no-frameworks, Build new ios production no-frameworks, Build RN 0.73.2 legacy hermes ios production no, Build RN 0.73.2 new hermes ios production no should be related with the fix CI flipper error
  • Build RN 0.73.2 legacy hermes ios production static, Build RN 0.73.2 legacy hermes ios production dynamic, Build RN 0.73.2 new hermes ios production static could also be related with the above.
  • the End-to-End Tests / metrics (legacy, android) (pull_request), End-to-End Tests / metrics (new, ios) (pull_request) is a known issue

(cherry picked from commit f5fb735)
(cherry picked from commit 434f32e)
Add the unreleased section to let the release script create the hotfix version section

Co-authored-by: Karl Heinz Struggl <[email protected]>
(cherry picked from commit 2116b5e)
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
The tests should be passing before merging, but other than that the PR looks good!

@lucas-zimerman
Copy link
Collaborator

lucas-zimerman commented Sep 19, 2024

@antonis I saw the following error messages on the CI tests:

error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Could you try updating the branch locally and update (yarn install) the samples and the SDK project?

Let me know if you need any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants