Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Remove deprecated Spotlight options #4086

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Refactoring

📜 Description

Clean up deprecated options.
please link to the issue here. -->

💚 How did you test it?

unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit 8d97167 into v6 Sep 12, 2024
52 of 53 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/remove-deprecated-spotloght-options branch September 12, 2024 19:57
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 462.58 ms 474.11 ms 11.53 ms
Size 17.74 MiB 20.06 MiB 2.33 MiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902 484.04 ms 487.57 ms 3.53 ms

App size

Revision Plain With Sentry Diff
f77a902 17.74 MiB 20.06 MiB 2.33 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.55 ms 1235.22 ms 7.67 ms
Size 2.36 MiB 3.08 MiB 733.35 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1227.09 ms 1226.74 ms -0.35 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.36 MiB 3.08 MiB 733.32 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.20 ms 1235.08 ms -1.12 ms
Size 2.92 MiB 3.64 MiB 739.10 KiB

Baseline results on branch: v6

Startup times

Revision Plain With Sentry Diff
f77a902+dirty 1223.83 ms 1227.98 ms 4.15 ms

App size

Revision Plain With Sentry Diff
f77a902+dirty 2.92 MiB 3.64 MiB 739.16 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants