feat(nestjs): add SentryGlobalGenericFilter and allow specifying application ref in global filter
#13673
+415
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
requested changes
Sep 19, 2024
| * Catches exceptions and reports them to Sentry unless they are HttpExceptions. | ||
| */ | ||
| public catch(exception: unknown, host: ArgumentsHost): void { | ||
| if (host.getType<'graphql'>() === 'graphql') { |
There was a problem hiding this comment.
We could think about checking for both host types 'graphql' and 'http' and otherwise provide a warning for an unsupported host type, wdyt?
| } | ||
|
|
||
| /** | ||
| * Catches exceptions and reports them to Sentry unless they are HttpExceptions. |
There was a problem hiding this comment.
Suggested change
| * Catches exceptions and reports them to Sentry unless they are HttpExceptions. | |
| * Catches exceptions and forwards them to the according error filter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a hybrid nestjs application should create its own global filter, since there is no way to use both http and graphql exception filters from sentry. This adds a new filter that uses the correct filter based on the context.
The new filter should also be usable for http-only and graphql-only applications, so it could be possible to deprecate the other filters.
These changes also allow the application ref to be set in the
SentryGlobalFilter, which can be nice if the filter is registered withapp.useGlobalFilters()