Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert license to original rrweb license #91

Closed
wants to merge 1 commit into from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 6, 2023

While setting up the publishing process for our rrweb fork, we changed the LICENSE text (#18). This was recently pointed out in [link]. It's worth noting that our fork was also always MIT-licensed, however, we changed the copyright which incorrectly suggested that the repo's code was ours. I'm not entirely sure what the reason for the change was back then but in hindsight this shouldn't have happened and I'm sorry for causing any confusion associated with this change.

This PR therefore reverts the license text back to rrweb's original license text.

@chadwhitacre
Copy link
Member

Conclusion in private Slack conversation (including Legal) is to go with something like this for LICENSE:

This project is forked from rrweb-io/rrweb under the MIT license:

[text of their copyright and license]

Our modifications are also released under the MIT license:

[text of our copyright and license]

@Lms24
Copy link
Member Author

Lms24 commented Jul 6, 2023

closing, superseded by #92

@Lms24 Lms24 closed this Jul 6, 2023
Lms24 added a commit that referenced this pull request Jul 6, 2023
While setting up the publishing process for our `rrweb` fork, we changed
the `LICENSE` text (#18) to our standard MIT license. This was recently
pointed out in rrweb-io#1248. While It's
worth noting that our fork was also always MIT-licensed, we did changed
the copyright, which incorrectly suggested that the repo's code was
ours. While I'm not entirely sure what the reason for the change was
back then, in hindsight this shouldn't have happened and I'm sorry for
causing any confusion associated with this change.

This patch adjusts the `LICENSE` file to include both, rrweb's original
license as well as our license text, which is what we settled on after
internal conversations (see
#91 (comment)).

---------

Co-authored-by: Chad Whitacre <[email protected]>
@chadwhitacre chadwhitacre deleted the lms/fix-license branch July 20, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants