Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task to force-process offline entities in submission backlog #1164

Closed
wants to merge 10 commits into from

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Jul 15, 2024

Closes getodk/central#682

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite
Copy link
Member Author

ktuite commented Aug 16, 2024

TODO as of aug 16

  • add tests of delay logic vs. force flag for only processing submissions held for a certain amount of time
  • change duration to be configurable in minutes for QA?
  • try it out more
  • add task to central cron job

@ktuite
Copy link
Member Author

ktuite commented Aug 20, 2024

Closing this PR in favor of restructured/split PR pair:

#1171 (clean up code, add other useful logic)
and
#1172 (add task to force process)

@ktuite ktuite closed this Aug 20, 2024
@ktuite ktuite deleted the ktuite/process_held_sub branch August 26, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a task to process offline entity submissions that have been held for a certain amount of time
1 participant