Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check approvalRequired reprocessing with offline entity queue #1162

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Jul 11, 2024

Small followup to getodk/central#669

Prevents submissions that are being held for later processing (because of offline entity ordering) are not mishandled

  • not reprocessed an extra time
  • not re-enqueued
  • not causing errors

This PR also tests the (expected) behavior that if an offline branch included create and update, and the dataset required approval before creating the update, that the update would be held until the create submission was approved and applied. (Though it gets pretty hairy on the Collect side to think about keeping all of this information/state in sync when combining approval required + offline. See forum post about ideas for syncing.)

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

Copy link
Member Author

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also file an issue for submission.reprocess event. Remove from verbose audit logs, remove from individual submission audit log?

test/integration/api/offline-entities.js Show resolved Hide resolved
@ktuite ktuite merged commit ca2df75 into master Jul 18, 2024
5 checks passed
@ktuite ktuite deleted the ktuite/offline_approval branch July 18, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants