http/endpoint: extract common pipe code #1113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2024 09:43
defaultResultWriter and odataJsonWriter use identical code for piping results to response. This commit extracts the shared code into its own function.
matthew-white
approved these changes
Oct 3, 2024
Comment on lines
+207
to
+209
| return true; | ||
| } | ||
| }; |
There was a problem hiding this comment.
I know undefined is falsy, but I think it'd be nice if the function returned false if it doesn't return true.
| @@ -192,20 +192,28 @@ const endpointBase = ({ preprocessor = noop, before = noop, resultWriter, errorW | |||
| // ENDPOINT FORMAT SPECIALIZATIONS | |||
|
|
|||
| //////////////////////////////////////// | |||
There was a problem hiding this comment.
I think this line comment goes together with the line comment on the next line, so the two should be moved together. I think the two lines should come before defaultResultWriter()/defaultErrorWriter()/defaultEndpoint(), similar to how there are line comments a bit above odataJsonWriter()/odataXmlErrorWriter()/odataJsonEndpoint()/etc. (the // ODATA comment and the line above it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultResultWriter and odataJsonWriter use identical code for piping results to response. This commit extracts the shared code into its own function.
Follow-up to #1110