fix: disable exhaustive dep (#1743)

getlago · Sep 18, 2024 · a84a0bf · a84a0bf
1 parent f290f3c
commit a84a0bf
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 10 deletions.
diff --git a/src/components/customers/overview/CustomerOverview.tsx b/src/components/customers/overview/CustomerOverview.tsx
@@ -119,6 +119,7 @@ export const CustomerOverview: FC<CustomerOverviewProps> = ({
     if (hasPermissions(['analyticsView'])) {
       getCustomerGrossRevenues()
     }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [externalCustomerId])
 
   const grossRevenues = (grossRevenuesData?.grossRevenues.collection || []).reduce(

diff --git a/src/pages/CustomerRequestOverduePayment/index.tsx b/src/pages/CustomerRequestOverduePayment/index.tsx
@@ -166,17 +166,25 @@ const CustomerRequestOverduePayment: FC = () => {
   )
   const totalInvoices = invoicesCollection.length
 
-  useEffect(() => {
-    if (hasDefinedGQLError('NotFound', error, 'customer')) {
-      navigate(ERROR_404_ROUTE)
-    }
-  }, [error])
+  useEffect(
+    () => {
+      if (hasDefinedGQLError('NotFound', error, 'customer')) {
+        navigate(ERROR_404_ROUTE)
+      }
+    },
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    [error],
+  )
 
-  useEffect(() => {
-    if (loading === false && totalAmount <= 0) {
-      navigate(ERROR_404_ROUTE)
-    }
-  }, [loading, totalAmount])
+  useEffect(
+    () => {
+      if (loading === false && totalAmount <= 0) {
+        navigate(ERROR_404_ROUTE)
+      }
+    },
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    [loading, totalAmount],
+  )
 
   return (
     <>