Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: move invoice numbering outside DB transaction #2621

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lovrocolic
Copy link
Collaborator

Context

Currently invoice numbering requires locking scope on invoices table.

Description

This PR moves invoice numbering logic to the very end of the invoice generation process (outside DB transaction). With this approach, lock duration is decreased and it it less likely to face SequenceError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants