fix(subscription): Fix generating invoice with pending downgrade #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
fix-timezone-upgrade
branch
3 times, most recently
from
2350ffb
to
f1e9bc8
Compare
vincent-pochet
changed the title
vincent-pochet
force-pushed
the
fix-timezone-upgrade
branch
2 times, most recently
from
3575c8e
to
2c86dce
Compare
vincent-pochet
force-pushed
the
fix-timezone-upgrade
branch
from
2c86dce
to
20c6d61
Compare
brunomiguelpinto
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Invoice for subscription termination are stuck in a
generatingstatus when the subscription is attached to a next subscription withpendingstatus.NOTE: A
terminatedsubscription should never be attached to a pending subscription, as next possible status should be either,activeorcanceled. The initial issue seems to be related to a race condition with multiple simultaneous upgrades and downgrades.Description
This PR does not fixes the initial issue but it makes sure that the
Subscriptions::DatesService#to_datetimecannot returns a date before the start date of the subscription