Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused refactor codes #2288

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:

- name: Clone LSP tests
run: |
git clone https://github.com/getgauge/gauge-lsp-tests
git clone https://github.com/dorion/gauge-lsp-tests
cd gauge-lsp-tests
npm install

Expand Down
47 changes: 0 additions & 47 deletions api/apiMessageHandler.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ import (
"github.com/getgauge/gauge/logger"
"github.com/getgauge/gauge/parser"
"github.com/getgauge/gauge/plugin"
"github.com/getgauge/gauge/refactor"
"github.com/getgauge/gauge/runner"
"github.com/getgauge/gauge/util"
"google.golang.org/protobuf/proto"
)

Expand Down Expand Up @@ -57,9 +55,6 @@ func (handler *gaugeAPIMessageHandler) MessageBytesReceived(bytesRead []byte, co
responseMessage = handler.getLanguagePluginLibPath(apiMessage)
case gauge_messages.APIMessage_GetAllConceptsRequest:
responseMessage = handler.getAllConceptsRequestResponse(apiMessage)
case gauge_messages.APIMessage_PerformRefactoringRequest:
responseMessage = handler.performRefactoring(apiMessage)
handler.performRefresh(responseMessage.PerformRefactoringResponse.FilesChanged)
case gauge_messages.APIMessage_ExtractConceptRequest:
responseMessage = handler.extractConcept(apiMessage)
case gauge_messages.APIMessage_FormatSpecsRequest:
Expand Down Expand Up @@ -180,48 +175,6 @@ func (handler *gaugeAPIMessageHandler) createGetAllConceptsResponseMessageFor(co
return &gauge_messages.GetAllConceptsResponse{Concepts: conceptInfos}
}

func (handler *gaugeAPIMessageHandler) performRefactoring(message *gauge_messages.APIMessage) *gauge_messages.APIMessage {
refactoringRequest := message.PerformRefactoringRequest
response := &gauge_messages.PerformRefactoringResponse{}
c := make(chan bool)
runner, err := ConnectToRunner(c, false)
defer func() {
err := runner.Kill()
if err != nil {
logger.Errorf(true, "failed to kill runner with pid: %d", runner.Pid())
}
}()
if err != nil {
response.Success = false
response.Errors = []string{err.Error()}
return &gauge_messages.APIMessage{MessageId: message.MessageId, MessageType: gauge_messages.APIMessage_PerformRefactoringResponse, PerformRefactoringResponse: response}
}
refactoringResult := refactor.GetRefactoringChanges(refactoringRequest.GetOldStep(), refactoringRequest.GetNewStep(), runner, handler.specInfoGatherer.SpecDirs, true)
refactoringResult.WriteToDisk()
if refactoringResult.Success {
logger.Infof(false, "%s", refactoringResult.String())
} else {
logger.Errorf(false, "Refactoring response from gauge. Errors : %s", refactoringResult.Errors)
}
response.Success = refactoringResult.Success
response.Errors = refactoringResult.Errors
response.FilesChanged = refactoringResult.AllFilesChanged()
return &gauge_messages.APIMessage{MessageId: message.MessageId, MessageType: gauge_messages.APIMessage_PerformRefactoringResponse, PerformRefactoringResponse: response}
}

func (handler *gaugeAPIMessageHandler) performRefresh(files []string) {
for _, file := range files {
if util.IsConcept(file) {
handler.specInfoGatherer.OnConceptFileModify(file)
}
}
for _, file := range files {
if util.IsSpec(file) {
handler.specInfoGatherer.OnSpecFileModify(file)
}
}
}

func (handler *gaugeAPIMessageHandler) extractConcept(message *gauge_messages.APIMessage) *gauge_messages.APIMessage {
request := message.GetExtractConceptRequest()
success, err, filesChanged := conceptExtractor.ExtractConcept(request.GetConceptName(), request.GetSteps(), request.GetConceptFileName(), request.GetChangeAcrossProject(), request.GetSelectedTextInfo())
Expand Down
1 change: 1 addition & 0 deletions api/lang/logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ func logInfo(req *jsonrpc2.Request, msg string, args ...interface{}) {
logToLsp(lsp.Info, m)
}

//nolint:all TODO: remove if this function will use
func logWarning(req *jsonrpc2.Request, msg string, args ...interface{}) {
m := fmt.Sprintf(getLogFormatFor(req, msg), args...)
logger.Warningf(false, m)
Expand Down
113 changes: 0 additions & 113 deletions api/lang/rename.go

This file was deleted.

183 changes: 0 additions & 183 deletions api/lang/rename_test.go

This file was deleted.

Loading