fix: remove infinite loop in subscription causing high cpu #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
reviewed
Jan 5, 2024
service.go
Outdated
| svc.Logger.Errorf("Subscription error %v", ctx.Err()) | ||
| return ctx.Err() | ||
| } | ||
| svc.Logger.Info("Exiting subscription.") |
There was a problem hiding this comment.
if the connection fails we have to wait and retry the connection. is this unaffected?
There was a problem hiding this comment.
@bumi I tested it against a locally-running relay. There was an issue which I fixed in dd59887.
We currently do not wait but immediately retry - I added a temporary 10 second sleep to test it and it successfully reconnects after I shut down the relay (killing the connection) and restart it.
If the relay cannot be immediately re-connected to, NWC will close. So maybe we should wait (however we haven't been doing that and it seems to work)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205