chore: replace publish response with a channel #463
Conversation
| Response: resp, | ||
| Tags: &nostr.Tags{}, | ||
| } | ||
| close(respChan) |
There was a problem hiding this comment.
Does using channels actually make this code easier and more readable? and why do we need to close here every single time?
There was a problem hiding this comment.
So that we can also use the same channel for multi-pay/mutli-keysend requests where there might be more than one message on the channel
There was a problem hiding this comment.
hmm, to be honest just having one function to call seems simpler to me
|
@im-adithya thanks for looking into this. I chatted about it with Bumi and we agreed it does not really make things simpler or more understandable and maybe this can be better solved in the future with middleware for example, which might be able to be addressed as part of getAlby/hub#52 in the future. I will close this for now. |
No description provided.