Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

chore: rename custom_records to tlv_records #448

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

bumi
Copy link

@bumi bumi commented Jun 14, 2024

This makes it more consistent with the usage in the keysend functions

This makes it more consistent with the usage in the keysend functions
@bumi bumi requested a review from rolznz June 14, 2024 19:16
@rolznz
Copy link
Collaborator

rolznz commented Jun 15, 2024

@bumi if we want to make it consistent I would also change the layout of the TLV records to match the NIP-47 spec. Is that ok? I can make the change.

"tlv_records: [ // tlv records, optional
            {
                "type": 5482373484, // tlv type
                "value": "0123456789abcdef" // hex encoded tlv value
            }
        ]

@bumi
Copy link
Author

bumi commented Jun 15, 2024

true, makes sense. can you add this?

(damn, then I need to convert it back in the rails app to handle it like lndhub/lnd :) )

@rolznz
Copy link
Collaborator

rolznz commented Jun 17, 2024

@bumi updated here and getAlby/lightning-browser-extension#3172

@rolznz rolznz merged commit 6bf900e into master Jun 17, 2024
7 checks passed
@rolznz rolznz deleted the rename-custom-records branch June 17, 2024 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants