Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Split service into packages #435

Merged
merged 18 commits into from
Jun 17, 2024
Merged

Split service into packages #435

merged 18 commits into from
Jun 17, 2024

Conversation

rolznz
Copy link
Collaborator

@rolznz rolznz commented Jun 12, 2024

Closes getAlby/hub#89

TODOs

  • global logger
  • isolate nip-47 handlers (move to separate layer, not be part of NIP-47 service)
  • Split up tests and move them into the packages they are testing
  • remove getters on service - move to new issue
  • config should not know about nostr keys
  • reduce duplication in multi_methods
  • move http entrypoint to cmd/http
  • Re-test everything
    • Wails mode (+ logger, graceful shutdown)
    • Channel creation (normal + LSP)
    • Backups
    • New app connections
    • NIP-47 commands
    • NIP-47 notifications
    • multi-* methods
    • http mode: graceful shutdown
    • build works on fly (http commands have been updated)
    • test RPI build
    • ...

@rolznz rolznz changed the title chore: split service into packages (WIP) Split service into packages Jun 16, 2024
@rolznz rolznz marked this pull request as ready for review June 16, 2024 16:56
@rolznz rolznz merged commit d06b421 into master Jun 17, 2024
7 checks passed
@rolznz rolznz deleted the chore/refactor-split-service branch June 17, 2024 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go cleanup (Part 2)
1 participant