Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Commit

Permalink
chore: bump import-codesign-certs version and disable notarization fo…
Browse files Browse the repository at this point in the history
…r non-release Wails macOS builds (#527)

Co-authored-by: Roman Dmitrienko <[email protected]>
  • Loading branch information
rdmitr and Roman Dmitrienko authored Jun 27, 2024
1 parent d12cb8e commit ad06b1b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ jobs:

build-wails:
uses: ./.github/workflows/wails.yml
with:
build-release: true
secrets:
APPLE_DEVELOPER_CERTIFICATE_P12_BASE64: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_P12_BASE64 }}
APPLE_DEVELOPER_CERTIFICATE_PASSWORD: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_PASSWORD }}
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/wails.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ on:
push:

workflow_call:
inputs:
build-release:
description: "Build full-featured release (codesigning, notarization, etc.)"
type: boolean
secrets:
APPLE_DEVELOPER_CERTIFICATE_P12_BASE64:
required: true
Expand Down Expand Up @@ -112,7 +116,7 @@ jobs:

- name: Import Code-Signing Certificates for macOS
if: runner.os == 'macOS'
uses: Apple-Actions/import-codesign-certs@v1
uses: Apple-Actions/import-codesign-certs@v3
with:
# The certificates in a PKCS12 file encoded as a base64 string
p12-file-base64: ${{ secrets.APPLE_DEVELOPER_CERTIFICATE_P12_BASE64 }}
Expand Down Expand Up @@ -196,7 +200,7 @@ jobs:
mv ./build/out/${{ env.PACKAGE_NAME }}.dmg ./build/bin/
- name: Notarize the DMG image
if: runner.os == 'macOS'
if: runner.os == 'macOS' && inputs.build-release
run: |
echo "Notarizing Zip Files"
gon -log-level=info -log-json ./build/darwin/gon-notarize.json
Expand Down

0 comments on commit ad06b1b

Please sign in to comment.