Skip to content

Commit

Permalink
fix: rename window object
Browse files Browse the repository at this point in the history
  • Loading branch information
@reneaaron
reneaaron committed Aug 9, 2023
1 parent 1eb3fd0 commit c538347
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/window.js
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// assign alby-tools exports to global window object (for index.browser.js)
// @ts-ignore
window["albyTools"] = require('./index.cjs');
window["lightningTools"] = require('./index.cjs');

3 comments on commit c538347

@bumi
Copy link
Contributor

@bumi bumi commented on c538347 Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we alias and deprecate it? I feel like this is at this point an unnecessary breaking change.

@reneaaron
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was the reason we introduced a new major version (4.0) initially, I just forgot to about the window object 🙈 if you really want it, feel free to add it...

@bumi
Copy link
Contributor

@bumi bumi commented on c538347 Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually do. because it is just a variable definition. so why does it need to be a sudden breaking change

Please sign in to comment.