chore: reorder and use wallet name from lud16 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this does not truly fix the root issue described in #126 which is that we shouldn't even save a new wallet until it's correctly configured. Would it be good to implement this too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
Fixes #127
The fix for 127 is made in such a way that now the user can create a wallet and then in the Setup Wallet screen, they will see a trash icon which is the only way to go back (thereby deleting the wallet without any nwc string)
Delete unset wallets
1) Trash Icon
2) If app is killed in that screen (1) and opened again, the wallet is shown like this
On clicking the wallet to select, you will be redirected to set it up
Reordering and using LUD16
1) Setup wallet
2a) LUD 16 is used as name from string
2b) If LUD 16 is not available
3) Success!