Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide passwords during execution #532

Merged
merged 2 commits into from Dec 6, 2023
Merged

Hide passwords during execution #532

merged 2 commits into from Dec 6, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 28, 2023

Hi,

This small pull request allows user to hide current plain-text passwords into execution output with the new variable mysql_hide_passwords.
The default value of this variable is false to allow users to activate this feature if they need it with a minimal impact on their current usage.

Thank you.

@ghost ghost closed this Nov 29, 2023
@ghost ghost reopened this Nov 29, 2023
@ghost
Copy link
Author

ghost commented Nov 29, 2023

Closing/Reopening was the only way I found to trigger tests again.

@ghost
Copy link
Author

ghost commented Dec 5, 2023

Hi,

I created another branch for CI into my forked repository: https://github.com/ptomas-adacis/ansible-role-mysql/commits/run_ci

The CI workflow is failing because of this known ansible bug: ansible/ansible#82264

The last commit of my branch (https://github.com/ptomas-adacis/ansible-role-mysql/commit/355fb248560a30799ca8018c1493768d4b9b556b) is applying this workaround: ansible/ansible#82264 (comment) to run the CI workflow without triggering the ansible bug.

As you can see here: https://github.com/ptomas-adacis/ansible-role-mysql/actions/runs/7099722877 the CI workflow is now running successfully.

Thank you

@geerlingguy
Copy link
Owner

Can you add that fix to this PR and I'll merge it? (ping me if I forget!)

@geerlingguy geerlingguy merged commit 8c87b67 into geerlingguy:master Dec 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant