Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: if image has been uploaded, return image url insead of error #251

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

tisfeng
Copy link

@tisfeng tisfeng commented Jun 14, 2024

Summary of this pull request

If the uploaded image name is duplicated, an error message will prompt that "sha wasn't supplied". The recent update made the following optimizations:

  1. If the uploaded image name already exists and has the same sha value, it will directly return the URL of that image.
  2. If the uploaded image name already exists but has a different sha value (indicating a different image with the same name), it will upload again with a randomly generated image name.

I tested it and it runs well, so I released an updated version 1.4.3 , just in case any other users might need it.

Does this solve an existing issue? If so, add a link to it

Refer to #238

Steps to test this feature

Screenshots

Additional info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant