Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve encoding of localized EAC log files #331

Conversation

c72578
Copy link
Collaborator

@c72578 c72578 commented Jun 7, 2024

EAC log files are encoded using UTF-16LE since version 1.0 beta 1.
Since #51 (commit 9f80400) this encoding is preserved in case of EAC
log files, which contain a log checksum. However, only English log
files have been supported so far.

  • Also preserve the encoding of EAC log files in different languages,
    if they contain a log checksum.
  • Just in case an EAC log file with a checksum has been converted
    to EOL LF, which is fine for CheckLog.exe, preserve UTF-16LE too.
  • Resolves CUETools: EAC log file encoding not always preserved #330

@c72578
Copy link
Collaborator Author

c72578 commented Jun 7, 2024

Here is a build for testing (updated):

CUETools_2.2.5_2024-06-10_git_4deaf3f_Preserve_encoding_of_localized_EAC_log_files.zip
SHA256: aa8c52932698a3f8d898357c1fd41bc77fd27a7cfd94474d72c161f179dea3ae

EAC log files are encoded using UTF-16LE since version 1.0 beta 1.
Since gchudov#51 (commit 9f80400) this encoding is preserved in case of EAC
log files, which contain a log checksum. However, only English log
files have been supported so far.

- Also preserve the encoding of EAC log files in different languages,
  if they contain a log checksum.
- Just in case an EAC log file with a checksum has been converted
  to EOL LF, which is fine for CheckLog.exe, preserve UTF-16LE too.
- Resolves gchudov#330
@c72578 c72578 force-pushed the 2024-06-07_Preserve_encoding_of_localized_EAC_log_files branch from f47154d to 4deaf3f Compare June 10, 2024 19:42
@c72578 c72578 merged commit 4deaf3f into gchudov:master Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUETools: EAC log file encoding not always preserved
1 participant