only publish to ghcr.io if pipeline runs on main branch #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vincinator
commented
Jul 29, 2024
Vincinator
commented
- main branch has branch protection, so only maintainers must be allowed to trigger publish process (which is enforced already)
- PR pipelines need to check if build works, so we must skip publishing in order to get green pipelines
* main branch has branch protection, so only maintainers must be allowed to trigger publish process (which is enforced already) * PR pipelines need to check if build works, so we must skip publishing in order to get green pipelines
fwilhe
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
LGTM, should enable PR builds to work properly and will avoid unneeded publication of PR built images
More improvements and consolidation can be done afterwards
thanks @Vincinator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.