Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making get_repo, get_timestamp, get_commit, get_version files optional #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MalteJ
Copy link
Member

@MalteJ MalteJ commented Jun 17, 2023

No description provided.

@MalteJ MalteJ requested a review from gehoern June 17, 2023 12:53
@gardener-robot
Copy link
Contributor

@MalteJ Thank you for your contribution.

@gardener-robot gardener-robot added the needs/review Needs review label Jun 17, 2023
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Jun 17, 2023
builder/Makefile Outdated Show resolved Hide resolved
builder/Makefile Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jun 19, 2023
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jun 19, 2023
@MalteJ
Copy link
Member Author

MalteJ commented Jun 19, 2023

how can we add a default keyring.gpg that can we overwritten by the user?

@gardener-robot
Copy link
Contributor

@gehoern You have pull request review open invite, please check

@Akendo
Copy link
Contributor

Akendo commented Sep 5, 2024

@MalteJ is this PR still relevant for you?

Copy link
Contributor

@Akendo Akendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@fwilhe
Copy link
Member

fwilhe commented Sep 5, 2024

I don't know if this works but 'bookworm' is not a good default meanwhile as trixie is the current base for Garden Linux.

Not sure what about the changes @nkraetzschmar asked for is fulfilled now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/changes Needs (more) changes needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants