Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check if referenced feature does exist #40

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

Vincinator
Copy link
Contributor

What this PR does / why we need it:

If a feature references a non existing featute, then the builder should exit with an error message telling the user that this feature does not exist.

Which issue(s) this PR fixes:
Fixes #22

fixes #22

If a feature references a non existing featute,
then the builder should exit with an error message telling
the user that this feature does not exist.
@gardener-robot
Copy link
Contributor

@Vincinator Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 26, 2023
@fwilhe
Copy link
Member

fwilhe commented Dec 19, 2023

Thanks for taking care 💯

@fwilhe fwilhe merged commit d335eb9 into main Dec 19, 2023
2 checks passed
@fwilhe fwilhe deleted the 22-better-error-messages branch December 19, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message if feature folder does not contain info.yaml
3 participants