Merge pull request #476 from jfortin-sap/condense-command

Condense commands in `gardenctl infra orphan list`
gardener-attic · Dec 1, 2020 · 30c1445 · 30c1445
2 parents d47972a + 9b3e0d2
commit 30c1445
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 46 deletions.
diff --git a/pkg/cmd/infra.go → pkg/cmd/orphan.go b/pkg/cmd/infra.go → pkg/cmd/orphan.go
@@ -27,62 +27,49 @@ import (
 	"github.com/spf13/cobra"
 )
 
-// NewInfraCmd returns a new infra command
-func NewInfraCmd(targetReader TargetReader) *cobra.Command {
+// NewOrphanCmd returns a new orphan command
+func NewOrphanCmd(targetReader TargetReader) *cobra.Command {
 	return &cobra.Command{
-		Use:          "infra [(orphan)] [(list)]",
-		Short:        "Manage shoot infra resources\n",
+		Use:          "orphan",
+		Short:        "List shoot resources that do not exist in the Gardener terraform state\n",
 		SilenceUsage: true,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			target := targetReader.ReadTarget(pathTarget)
 			if !CheckShootIsTargeted(target) {
 				return errors.New("no shoot targeted")
 			}
-			if len(args) < 2 || len(args) > 2 {
-				return errors.New("command must be in the format: infra [orphan] [list]")
+			var rs []string
+			pathTerraformState := filepath.Join(downloadTerraformFiles("infra", targetReader), "terraform.tfstate")
+			buf, err := ioutil.ReadFile(pathTerraformState)
+			if err != nil || len(buf) < 64 {
+				fmt.Println("Could not read terraform.tfstate: " + pathTerraformState)
+				os.Exit(2)
 			}
-			switch args[0] {
-			case "orphan":
-				switch args[1] {
-				case "list":
-					var rs []string
-					pathTerraformState := filepath.Join(downloadTerraformFiles("infra", targetReader), "terraform.tfstate")
-					buf, err := ioutil.ReadFile(pathTerraformState)
-					if err != nil || len(buf) < 64 {
-						fmt.Println("Could not read terraform.tfstate: " + pathTerraformState)
-						os.Exit(2)
-					}
-					terraformstate := string(buf)
+			terraformstate := string(buf)
 
-					shoot, err := FetchShootFromTarget(target)
-					checkError(err)
-					infraType := shoot.Spec.Provider.Type
-
-					switch infraType {
-					case "aws":
-						rs = getAWSInfraResources(targetReader)
-					case "azure":
-						rs = getAzureInfraResources(targetReader)
-					case "gcp":
-						rs = getGCPInfraResources(targetReader)
-					case "openstack":
-						rs = getOstackInfraResources(targetReader)
-					case "alicloud":
-						rs = getAliCloudInfraResources(targetReader)
-					default:
-						return errors.New("infra type not found")
-					}
-
-					err = GetOrphanInfraResources(rs, terraformstate)
-					checkError(err)
-					fmt.Printf("\n\nsearched %s\n", pathTerraformState)
-				default:
-					fmt.Println("command must be in the format: infra [orphan] [list]")
-				}
+			shoot, err := FetchShootFromTarget(target)
+			checkError(err)
+			infraType := shoot.Spec.Provider.Type
+
+			switch infraType {
+			case "aws":
+				rs = getAWSInfraResources(targetReader)
+			case "azure":
+				rs = getAzureInfraResources(targetReader)
+			case "gcp":
+				rs = getGCPInfraResources(targetReader)
+			case "openstack":
+				rs = getOstackInfraResources(targetReader)
+			case "alicloud":
+				rs = getAliCloudInfraResources(targetReader)
 			default:
-				fmt.Println("command must be in the format: infra [orphan] [list]")
+				return errors.New("infra type not found")
 			}
 
+			err = GetOrphanInfraResources(rs, terraformstate)
+			checkError(err)
+			fmt.Printf("\n\nsearched %s\n", pathTerraformState)
+
 			return nil
 		},
 		ValidArgs: []string{"orphan"},

diff --git a/pkg/cmd/infra_test.go → pkg/cmd/orphan_test.go b/pkg/cmd/infra_test.go → pkg/cmd/orphan_test.go
@@ -20,7 +20,7 @@ import (
 	. "github.com/onsi/gomega"
 )
 
-var _ = Describe("Infra", func() {
+var _ = Describe("Orphan", func() {
 	var rs = []string{"vpc-03cb057da4ded427f"}
 	terraformstate := `
 },

diff --git a/pkg/cmd/root.go b/pkg/cmd/root.go
@@ -154,7 +154,7 @@ func init() {
 	RootCmd.AddCommand(NewKubectlCmd(), NewKaCmd(), NewKsCmd(), NewKgCmd(), NewKnCmd())
 	RootCmd.AddCommand(NewKubectxCmd())
 	RootCmd.AddCommand(NewTerraformCmd(targetReader))
-	RootCmd.AddCommand(NewInfraCmd(targetReader))
+	RootCmd.AddCommand(NewOrphanCmd(targetReader))
 	RootCmd.AddCommand(NewAliyunCmd(targetReader), NewAwsCmd(targetReader), NewAzCmd(targetReader), NewGcloudCmd(targetReader), NewOpenstackCmd(targetReader))
 	RootCmd.AddCommand(NewInfoCmd(targetReader, ioStreams))
 	RootCmd.AddCommand(NewVersionCmd(), NewUpdateCheckCmd())