Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluka viewer #46

Merged
merged 6 commits into from
Jul 11, 2023
Merged

Fluka viewer #46

merged 6 commits into from
Jul 11, 2023

Conversation

stewartboogert
Copy link
Member

@stewartboogert stewartboogert commented Jul 6, 2023

Working FLUKA viewer. Appears to work well with hang (FLAIR) authored geometry. There are still issues with converted geometry, but the problematic regions will be output to the terminal and skipped.

Example usage

r = pyg4ometry.fluka.Reader("./FLUKA_FILE.inp")
v = pyg4ometry.visualisation.VtkViewerNew()
v.addFlukaRegions(r.getRegistry())
v.buildPipelinesAppend()
v.view()

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #46 (235bf02) into main (911fbce) will increase coverage by 0.52%.
The diff coverage is 44.82%.

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   70.00%   70.53%   +0.52%     
==========================================
  Files         144      144              
  Lines       21036    21065      +29     
==========================================
+ Hits        14727    14858     +131     
+ Misses       6309     6207     -102     
Impacted Files Coverage Δ
src/pyg4ometry/fluka/region.py 75.56% <12.50%> (-2.35%) ⬇️
src/pyg4ometry/visualisation/ViewerBase.py 23.19% <84.61%> (+10.79%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lnevay
Copy link
Contributor

lnevay commented Jul 10, 2023

"dumpsDebug" could perhaps be named a little better. Other than that, all good and great to see.

@stewartboogert
Copy link
Member Author

"dumpsDebug" could perhaps be named a little better. Other than that, all good and great to see.

This is to be consistent with the existing naming. Will change them all (dumps) in a future fluka refactor

@lnevay lnevay merged commit 5317f5b into g4edge:main Jul 11, 2023
11 checks passed
@stewartboogert stewartboogert deleted the flukaViewer branch July 17, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants