-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move old tests #36
Move old tests #36
Conversation
There is a pre-commit check called "python tests naming" that complains about test files not being named |
So this fixture here: Lines 17 to 25 in 2f1f57b
used, for example, here: pyg4ometry/tests/stl/test_stl_load.py Line 36 in 2f1f57b
sets up a random directory in |
Non-Python files in |
I see you depend on PyROOT for some tests, which is not available in CI. We should discuss how to install this dependency, if it's really necessary... |
I was going to ask. Fixtures is some cases is an excellent solution , but it does making running some code outside of purest cumbersome. I'll disable for now |
There is a converter from root and it would be great to test against. A standard root install in the docker image would be outstanding. Does not need to be anything magical, just working with the python we use. Should I disable them for now? |
Exellent I was going to ask how to do this. I am currently littering the directory structure with files which I want to suppress. |
Yes, please. Could you open an issue about PyROOT to keep track of it? |
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
===========================================
+ Coverage 24.24% 68.61% +44.36%
===========================================
Files 144 144
Lines 21024 21036 +12
===========================================
+ Hits 5098 14434 +9336
+ Misses 15926 6602 -9324
... and 82 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Moved most of the tests over