Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dxvk,vkd3d-proton: fix #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

LunNova
Copy link
Contributor

@LunNova LunNova commented Jul 12, 2023

Fixes #85

This gets them working again but isn't using npins any more.

@fufexan
Copy link
Owner

fufexan commented Jul 12, 2023

Do the archives not contain the submodules? I think that's an issue upstream needs to fix. I also made an issue in npins that would make it easier for us to use artifacts from releases: andir/npins#44.

In the meantime, unless someone updates these packages manually, we'd need an update script similar to the osu-lazer-bin one (or faf-client, but that's very complex).

@LunNova
Copy link
Contributor Author

LunNova commented Jul 12, 2023

The pins are using a tarball of the commit at the release generated by github which doesn't include submodules and I don't think the upstream project can change that.

@LunNova
Copy link
Contributor Author

LunNova commented Nov 1, 2023

This PR is now using npins at this PR: andir/npins#46 and can't be merged until that becomes part of an npins release

@LunNova LunNova marked this pull request as ready for review November 1, 2023 19:18
@LunNova LunNova mentioned this pull request Nov 2, 2023
@fufexan
Copy link
Owner

fufexan commented Feb 23, 2024

@LunNova while we're waiting on the merge of that PR, the dxvk derivation remains broken. I propose using npins from that branch, by including it in a devShell in this flake.

@LunNova
Copy link
Contributor Author

LunNova commented Feb 23, 2024

I propose using npins from that branch, by including it in a devShell in this flake.

@fufexan would you be okay taking over this PR and doing that part yourself?

Changing the update process for your flake feels like I'm likely to do things in ways you didn't intend and need back/forth reviewing.

Otherwise I can give it a shot when I have time

@fufexan
Copy link
Owner

fufexan commented Feb 23, 2024

Okay, I'll handle that. But first I want to ask the PR author whether it's going to be merged soon.

@fufexan
Copy link
Owner

fufexan commented Jul 13, 2024

@LunNova andir/npins#46 has been merged. Do you intend to continue working on this PR?
EDIT: nvm, forgot we need a release first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vkd3d and dxvk broken
2 participants