Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new category fs for file systems #302

Open
wants to merge 139 commits into
base: main
Choose a base branch
from
Open

Conversation

clausecker
Copy link
Contributor

@clausecker clausecker commented Sep 29, 2024

This patch set adds a new category fs for file systems and file system utilities. The new category is populated with some 126 ports (that's more than x11-clocks!) that look like they might be file-system related.

I was motivated to add this new category when I noticed that many FUSE file systems were shipped as ports named sysutils/fusefs-$foo, making sysutils/fusefs- a pseudo-category for FUSE filesystems. If that's the (anti) pattern, why not make it offical and add a true category for file system ports? Turns out there are a lot more than one might think.

I hope that with this move, we can reduce the load on devel and sysutils (the two most popular misspellings of misc) and make file-system related ports easier to find.

If accepted, this'll be the first new physical category since c5978f0 of 2007-05-19 to be added.

For a full list of affected ports, see the list of commits attached to this PR. If you would like to not have your port moved to fs, please comment or send me an email.

Note that this PR is still wip and will be reviewed, exp-ran, etc. before being committed.

@metalefty
Copy link
Member

I personally like that idea. That sounds reasonable because there are more ports than x11-clocks. BTW, I like filesystem(s) more than fs.

@rosorio
Copy link
Contributor

rosorio commented Sep 30, 2024 via email

@yurivict
Copy link
Member

+1 I like this idea too.

@Jehops
Copy link
Member

Jehops commented Oct 2, 2024

Robert, as we discussed in Dublin, I generally think creating a new fs category for filesystems is a good idea. However, I'm on the fence about moving utilities such as sysutils/zrepl or sysutils/zfs-snapshot-mgmt. If others agree that also moving those ports is beneficial, then we should make it clear in the comment in fs/Makefile that utilities related to filesystems also belong there.

Here are a few more for you:

commit 230cb49ccce5a79985875ad16e36da0b8f9e8c52
Author:     Emanuel Haupt <[email protected]>
AuthorDate: 2024-10-02 07:52:13 +0000
Commit:     Emanuel Haupt <[email protected]>
CommitDate: 2024-10-02 07:52:32 +0000

    sysutils/fusefs-mergerfs: Add new port
    
    mergerfs is a union filesystem geared towards simplifying storage and
    management of files across numerous commodity storage devices. It is
    similar to mhddfs, unionfs, and aufs.
  1. (If we decide fs utilities should also be moved)
% cat sysutils/zap/pkg-descr
Maintain and replicate ZFS snapshots

zap automates the management of zfs snapshots.  With a few, simple
crontab entries, it can be used to create a comprehensive zfs backup
system.  There are no configuration files.  All parameters are supplied
on the command line or in zfs properties and all snapshot information
is stored in snapshot names.

zap plays nice with manually created snapshots or snapshots from other
tools.  It will only operate on snapshots it creates.

@clausecker
Copy link
Contributor Author

@Jehops Thank you for your concerns.

The current comment was supposed to read:

COMMENT = File systems and utilities

but I must have dropped the second half during copy editing. I'll restore that in my next push. I am open to having a category for only file system drivers, but I would prefer to also put the fs utilities in there. We could also add two categories: one for file system drivers and one for associated utilities (e.g. fsutil or fs-mgmt).

I'll go add the other two ports, too.

@Jehops
Copy link
Member

Jehops commented Oct 2, 2024

COMMENT = File systems and utilities

Taking inspiration from existing comments, how about File systems and related utilities?

games/Makefile    COMMENT = Games and related software
databases/Makefile    COMMENT = Databases and related software
finance/Makefile    COMMENT = Monetary, financial, and related applications

@clausecker
Copy link
Contributor Author

@Jehops Yeah sure, works for me. I'll put that in with my next edit.

The fs category houses file systems and file system utilities.
It is added mainly to turn the sysutils/fusefs-* pseudo-category into
a proper one, but is also useful for the sundry of other file systems
related ports found in the tree.

Approved by:	portmgr
Approved by:	portmgr
Approved by:	portmgr
Approved by:	portmgr
Approved by:	portmgr
Approved by:	portmgr
Approved by:	portmgr
@diizzyy
Copy link
Contributor

diizzyy commented Oct 6, 2024

Why this is submitted to GitHub? It's not a supported way of submitting patches (see Porters Handbook). Submit it to bugzilla and continue the discussion there.

@clausecker
Copy link
Contributor Author

@Diizzy We do process pull requests against ports.

I have submitted this change set like this as it's much easier to review the 137 individual ports affected than it would be with a big patch on Phabricator or Bugzilla.

@bsdimp
Copy link
Member

bsdimp commented Oct 6, 2024

@diizzyy Other than "the rules" is there some good reason not do it here? It seems to have generated a reasonable amount of feedback so far.

@diizzyy
Copy link
Contributor

diizzyy commented Oct 6, 2024

@bsdimp A lot more eyes and participants on bugzilla (and indirectly mailing lists), there's little to no involvement/interraction with most of the community including committers etc on GitHub.

@bsdimp
Copy link
Member

bsdimp commented Oct 6, 2024

@diizzyy And bugzilla is the worst tool ever to review changes (even worse than phabricator). It's barely adequate as a conveyer belt for submissions. Github is much better, and can as easily be references in other forum as bugzilla. The current bugzilla workflow is unustainable, imho, and requires too much extra work. fuz's changes likely need detailed commentary, for which bugzilla is ill suited to do on a change this large. It can't handle 10 commits in one go, let alone 140. Since it is an imperfect fit, fuz will also need to seek review elsewhere (which I thought I'd seen an email go by that did), true, but going to bugzilla is setting him up to fail because it would be such a bad tool for a change like this.

@yurivict
Copy link
Member

yurivict commented Oct 6, 2024

And bugzilla is the worst tool ever to review changes [...]

This is off-topic here, but you probably have never seen Jira that is used by many companies.
Compared to Jira, Bugzilla is a totally sane and pleasant tool.


The key to your submission is not the exact list of ports, but the portmgr approval.
You need to contact somebody in the portmgr team and ask for approval.

Here is my proposal for the physics and chemistry categories from 2018 which is still not approved: https://reviews.freebsd.org/D13481

The FreeBSD Portmgr is a bit slow, don't you think?

@clausecker
Copy link
Contributor Author

@yurivict My original email went to ports@ as well as portmgr@ and explicitly asked for approval. I hope that suffices. If not, I'll bug portmgr some more (I encourage you to do the same about your proposal).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants