Snssai.Sd values to lower case #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-ywliu
reviewed
Jul 26, 2023
| @@ -1481,6 +1488,12 @@ func PolicyDataUesUeIdSmDataGetProcedure(collName string, ueId string, snssai mo | |||
| smPolicyDataResp.UmData[element.LimitId] = element | |||
| } | |||
| } | |||
|
|
|||
| for sstSd, snssaiData := range smPolicyDataResp.SmPolicySnssaiData { | |||
There was a problem hiding this comment.
no need this for loop
tim-ywliu
reviewed
Jul 26, 2023
| @@ -1456,6 +1460,9 @@ func PolicyDataUesUeIdSmDataGetProcedure(collName string, ueId string, snssai mo | |||
| } | |||
| tmpSmPolicySnssaiData := make(map[string]models.SmPolicySnssaiData) | |||
| for snssai, snssaiData := range smPolicyDataResp.SmPolicySnssaiData { | |||
| snssai = strings.ToLower(snssai) | |||
tim-ywliu
reviewed
Jul 26, 2023
| @@ -1535,6 +1556,12 @@ func PolicyDataUesUeIdSmDataPatchProcedure(collName string, ueId string, | |||
| logger.DataRepoLog.Warnln(err) | |||
| } | |||
|
|
|||
| for sstSd, snssaiData := range smPolicyData.SmPolicySnssaiData { | |||
There was a problem hiding this comment.
use a new map to add, and replace smPolicyData.SmPolicySnssaiData with the new map
tim-ywliu
approved these changes
Jul 27, 2023
tim-ywliu
added a commit
that referenced
this pull request
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for free5gc issue #435