feat: support SDM Subscription and Unsubscription for UE Session #123
Conversation
saileshvvr
force-pushed
the
udm_sdm_subscription_support
branch
from
dd8ef0b
to
24ef1ec
Compare
saileshvvr
force-pushed
the
udm_sdm_subscription_support
branch
2 times, most recently
from
479c658
to
3650397
Compare
|
@andy89923 |
andy89923
changed the title
saileshvvr
force-pushed
the
udm_sdm_subscription_support
branch
from
3650397
to
690c8a0
Compare
|
Hi @andy89923 , |
|
Hi @andy89923 |
There was a problem hiding this comment.
@saileshvvr Sorry for the late review!
After testing w/wo OAuth, this PR can subscribe when a new UE and unsubscribe when the UE's last PDU session is released.
Thanks for the PR, LGTM!
| @@ -121,6 +121,17 @@ func (p *Processor) HandlePDUSessionSMContextCreate( | |||
| } | |||
| } | |||
|
|
|||
| if !p.Context().Ues.UeExists(smContext.Supi) { | |||
There was a problem hiding this comment.
What if the error happens after the SDM data changed?
I think use the defer would be better in this case:
defer func(err error) {
if err != nil {
if !p.Context().Ues.UeExists(smContext.Supi) {
if problemDetails, err := p.Consumer().
Subscribe(ctx, smContext, smPlmnID); problemDetails != nil {
smContext.Log.Errorln("SDM Subscription Failed Problem:", problemDetails)
} else if err != nil {
smContext.Log.Errorln("SDM Subscription Error:", err)
}
} else {
p.Context().Ues.IncrementPduSessionCount(smContext.Supi)
}
}
}(err)| @@ -878,6 +898,15 @@ func (p *Processor) HandlePDUSessionSMContextRelease( | |||
| } | |||
| } | |||
|
|
|||
| if p.Context().Ues.UeExists(smContext.Supi) { | |||
There was a problem hiding this comment.
Same as above.
Please do this action by using defer.
| @@ -969,6 +998,15 @@ func (p *Processor) HandlePDUSessionSMContextLocalRelease( | |||
| } | |||
| } | |||
|
|
|||
| if p.Context().Ues.UeExists(smContext.Supi) { | |||
There was a problem hiding this comment.
Same as above.
Please do this action by using defer.
| @@ -325,6 +336,15 @@ func (p *Processor) HandlePDUSessionSMContextUpdate( | |||
| } | |||
| } | |||
|
|
|||
| if smf_context.GetSelf().Ues.UeExists(smContext.Supi) { | |||
There was a problem hiding this comment.
Same as above.
Please do this action by using defer.
|
It looks good to me except the requested changes. Hi @saileshvvr |
|
Hi @ianchen0119 , Thank you for the feedback. As I was occupied with other work, missed the comments. Thanks! |
|
Hi @saileshvvr , We can't use the defer function and pass the error to differentiate if the error happens after the defer function. func main() {
var err error
defer func() {
if err != nil {
fmt.Printf("defer: %s\n", err)
} else {
fmt.Println("defer: defer not error")
}
}()
err = errors.New("new error 1")
if err != nil {
return
}
}
/*output
defer: new error 1
*/You can refer to https://stackoverflow.com/questions/42703707/when-defer-func-evaluates-its-parameters |
|
Hi @andy89923 , @ianchen0119 , |
|
Hi @saileshvvr ,
No, we should revise this in the same PR. If you don't have time, I will help revise if the PR isn't ready until next Wednesday. |
|
Thank you @andy89923 . |
Description