-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heatmap] Adjusting grid calcualtion for consistent grid layout #161
Open
kimili
wants to merge
15
commits into
frappe:master
Choose a base branch
from
kimili:feature/heatmap-customize-month-names
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Heatmap] Adjusting grid calcualtion for consistent grid layout #161
kimili
wants to merge
15
commits into
frappe:master
from
kimili:feature/heatmap-customize-month-names
Commits on Apr 22, 2018
-
[Heatmap] Adjusting grid calcualtion for consistent grid layout
Date math is hard! This addresses a problem in how the heatmap lays calculates days to lay out the grid. The calculations were being thrown off in some scenarios by a combination of factors including timezone offsets, time of day, and daylight savings time. This patch should correct all this by forcing each day to be midnight UTC when laying out the grid.
Configuration menu - View commit details
-
Copy full SHA for 810c0aa - Browse repository at this point
Copy the full SHA 810c0aaView commit details
Commits on Apr 23, 2018
-
Configuration menu - View commit details
-
Copy full SHA for af48bbe - Browse repository at this point
Copy the full SHA af48bbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d32c46c - Browse repository at this point
Copy the full SHA d32c46cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e66a65 - Browse repository at this point
Copy the full SHA 3e66a65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 365c11c - Browse repository at this point
Copy the full SHA 365c11cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74de373 - Browse repository at this point
Copy the full SHA 74de373View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40f79a6 - Browse repository at this point
Copy the full SHA 40f79a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67b6ed8 - Browse repository at this point
Copy the full SHA 67b6ed8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 143fc1c - Browse repository at this point
Copy the full SHA 143fc1cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b209cb2 - Browse repository at this point
Copy the full SHA b209cb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1783b4c - Browse repository at this point
Copy the full SHA 1783b4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e6986e - Browse repository at this point
Copy the full SHA 7e6986eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d4b614 - Browse repository at this point
Copy the full SHA 0d4b614View commit details -
[Heatmap] Adjusting grid calcualtion for consistent grid layout
Date math is hard! This addresses a problem in how the heatmap lays calculates days to lay out the grid. The calculations were being thrown off in some scenarios by a combination of factors including timezone offsets, time of day, and daylight savings time. This patch should correct all this by forcing each day to be midnight UTC when laying out the grid.
Configuration menu - View commit details
-
Copy full SHA for 6672121 - Browse repository at this point
Copy the full SHA 6672121View commit details -
Merge branch 'develop' into feature/heatmap-customize-month-names
# Conflicts: # dist/frappe-charts.min.cjs.js # dist/frappe-charts.min.cjs.js.map # dist/frappe-charts.min.esm.js # dist/frappe-charts.min.esm.js.map # dist/frappe-charts.min.iife.js # dist/frappe-charts.min.iife.js.map # docs/assets/js/frappe-charts.min.js # docs/assets/js/frappe-charts.min.js.map # docs/assets/js/index.min.js # docs/assets/js/index.min.js.map # package-lock.json
Configuration menu - View commit details
-
Copy full SHA for a77e1fa - Browse repository at this point
Copy the full SHA a77e1faView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.