fix: set numberSeries as readOnly after insert

frappe · Apr 4, 2022 · ceb45b5 · ceb45b5
1 parent 54628bb
commit ceb45b5
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 10 deletions.
diff --git a/frappe/model/document.js b/frappe/model/document.js
@@ -69,6 +69,10 @@ export default class Document extends Observable {
       return;
     }
 
+    if (fieldname === 'numberSeries' && !this._notInserted) {
+      return;
+    }
+
     if (this[fieldname] !== value) {
       this._dirty = true;
       // if child is dirty, parent is dirty too

diff --git a/src/components/TwoColumnForm.vue b/src/components/TwoColumnForm.vue
@@ -86,10 +86,10 @@
   </div>
 </template>
 <script>
-import frappe from 'frappe';
-import FormControl from '@/components/Controls/FormControl';
 import Button from '@/components/Button';
-import { handleErrorWithDialog, getErrorMessage } from '../errorHandling';
+import FormControl from '@/components/Controls/FormControl';
+import frappe from 'frappe';
+import { getErrorMessage, handleErrorWithDialog } from '../errorHandling';
 
 let TwoColumnForm = {
   name: 'TwoColumnForm',
@@ -153,6 +153,10 @@ let TwoColumnForm = {
       }
     },
     evaluateReadOnly(df) {
+      if (df.fieldname === 'numberSeries' && !this.doc._notInserted) {
+        return true;
+      }
+
       if (this.submitted) {
         return true;
       }

diff --git a/src/pages/InvoiceForm.vue b/src/pages/InvoiceForm.vue
@@ -109,7 +109,7 @@
                   :df="meta.getField('numberSeries')"
                   :value="doc.numberSeries"
                   @change="(value) => doc.set('numberSeries', value)"
-                  :read-only="doc.submitted"
+                  :read-only="!doc._notInserted || doc.submitted"
                 />
               </div>
             </div>
@@ -205,11 +205,11 @@ import DropdownWithActions from '@/components/DropdownWithActions';
 import PageHeader from '@/components/PageHeader';
 import StatusBadge from '@/components/StatusBadge';
 import {
-getActionsForDocument,
-getInvoiceStatus,
-openSettings,
-routeTo,
-showMessageDialog
+  getActionsForDocument,
+  getInvoiceStatus,
+  openSettings,
+  routeTo,
+  showMessageDialog,
 } from '@/utils';
 import frappe from 'frappe';
 import { handleErrorWithDialog } from '../errorHandling';

diff --git a/src/pages/JournalEntryForm.vue b/src/pages/JournalEntryForm.vue
@@ -84,7 +84,7 @@
                   :value="doc.numberSeries"
                   @change="(value) => doc.set('numberSeries', value)"
                   input-class="bg-gray-100 p-2 text-base"
-                  :read-only="doc.submitted"
+                  :read-only="!doc._notInserted || doc.submitted"
                   :class="doc.submitted && 'pointer-events-none'"
                 />
             </div>