Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial not being found with different inflector #50

Conversation

emilioeduardob
Copy link
Contributor

I tried installing solid_errors on a spanish language project, it has inflection rules like:

ActiveSupport::Inflector.inflections do |inflect|
  inflect.plural /([aeiou])([A-Z]|_|$)/, '\1s\2'
  inflect.plural /([rlnd])([A-Z]|_|$)/, '\1es\2'
  inflect.plural /([aeiou])([A-Z]|_|$)([a-z]+)([rlnd])($)/, '\1s\2\3\4es\5'
  inflect.plural /([rlnd])([A-Z]|_|$)([a-z]+)([aeiou])($)/, '\1es\2\3\4s\5'
end

This causes the render of occurrences to look for the partial under the solid_errores path

This PR uses the full version of the render method

@fractaledmind fractaledmind merged commit 6a732a8 into fractaledmind:main Jun 21, 2024
4 checks passed
@fractaledmind
Copy link
Owner

Released version 0.4.3 now with this improvement

@emilioeduardob emilioeduardob deleted the fix-partial-on-non-en-inflection branch June 22, 2024 14:40
@emilioeduardob
Copy link
Contributor Author

Released version 0.4.3 now with this improvement

thanks for the quick release @fractaledmind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants