Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors index #25

Merged

Conversation

dorianmariecom
Copy link
Contributor

rails was passing the variable as "row" and not "error"

Visible when doing local_assigns

rails was passing the variable as "row" and not "error"
@dorianmariecom
Copy link
Contributor Author

dorianmariecom commented Feb 22, 2024

This can be fixed locally by creating a app/views/solid_errors/errors/index.html.erb file with:

<table class="min-w-full divide-y divide-gray-300">
  <thead>
    <tr>
      <th scope="col" class="py-3.5 pl-4 pr-3 text-left text-sm font-semibold text-gray-900 sm:pl-3">Error</th>
      <th scope="col" class="px-3 py-3.5 text-right text-sm font-semibold text-gray-900">Count</th>
      <th scope="col" class="px-3 py-3.5 text-right text-sm font-semibold text-gray-900">Last</th>
      <th scope="col" class="relative py-3.5 pl-3 pr-4 sm:pr-3">
        <span class="sr-only">Resolve</span>
      </th>
    </tr>
  </thead>

  <tbody class="bg-white">
    <%= render partial: "solid_errors/errors/row", collection: @errors, as: :error %>
  </tbody>
</table>

@fractaledmind fractaledmind merged commit 87e7e81 into fractaledmind:main Feb 22, 2024
1 check passed
@dorianmariecom dorianmariecom deleted the dorian/fix-errors-index branch February 22, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants