Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change theme colors #754

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

kprosise
Copy link
Contributor

Marketing requested change to the colors of the expand icon and the section headers in the sidebar.

Testing: Viewed rendered output in browser. No changes made to links or content.

This commit has no associated issue, quick fix.

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Minor tweaks to the theme.

Checklist

  • Match tone and style of page/section.
  • View HTML in a browser to check rendering.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Marketing requested change to the colors of the expand icon and the
section headers in the sidebar.

Testing: Viewed rendered output in browser. No changes made to links or
content.

This commit has no associated issue, quick fix.

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise requested review from brenwoo and a team September 18, 2024 11:09
@doanac
Copy link
Member

doanac commented Sep 18, 2024

@kprosise kprosise merged commit 5ef6a24 into foundriesio:main Sep 19, 2024
3 checks passed
@kprosise kprosise deleted the change-sidebar-expand-icon branch September 19, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants