Fix typo and style issues in lmp-customization #712
Conversation
|
Docs for b4c99f4 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2666/docs/artifacts/html/index.html |
| worker_tag: "amd64-partner-aws" | ||
| params: | ||
| IMAGE: lmp-factory-image | ||
| SSTATE_CACHE_MIRROR: "" |
There was a problem hiding this comment.
This SSTATE_CACHE_MIRROR line can be removed because it is not more in use
There was a problem hiding this comment.
not related with this PR but there are another reference for it that we can also erase
https://github.com/search?q=repo%3Afoundriesio%2Fdocs%20SSTATE_CACHE_MIRROR&type=code
There was a problem hiding this comment.
@quaresmajose do you know when it became deprecated? I want to see what I can come up with to help ensure these types of changes get reflected in the docs.
There was a problem hiding this comment.
It was deprecated since Nov 27, 2023 with the merge of foundriesio/ci-scripts#314.
There is no side effect of continuing to have this variable defined. it is simply ignored
There was a problem hiding this comment.
I'm sorry but it was actually my fault and I should also remove this from the documentation
There was a problem hiding this comment.
I got it, no worries!
|
Docs for cd6f7dd are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2667/docs/artifacts/html/index.html |
This commit removes 1 of 2 reference, with the other being included in PR foundriesio#712. QA Steps: Checked rendered output, no issues seen. No related ticket, small fix. Signed-off-by: Katrina Prosise <[email protected]>
Addressed issues to more closely adhere to the style-guide. Checked rendered output, and ran linter. No issues to report. No associated ticket, minor fix. Signed-off-by: Katrina Prosise <[email protected]>
kprosise
force-pushed
the
typo-fixes-lmp-customization
branch
from
cd6f7dd
to
b9c09a9
Compare
|
Docs for b9c09a9 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2669/docs/artifacts/html/index.html |
This commit removes 1 of 2 reference, with the other being included in PR #712. QA Steps: Checked rendered output, no issues seen. No related ticket, small fix. Signed-off-by: Katrina Prosise <[email protected]>
Addressed issues to more closely adhere to the style-guide.
Checked rendered output, and ran linter. No issues to report.
No associated ticket, minor fix.
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
make linkcheck.-s, --signoff).-S, --gpg-sign).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.