rm: factory: Add info on TUF targets expiration configuration #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs for f601843 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2601/docs/artifacts/html/index.html |
mike-sul
force-pushed
the
fix-tuf-targets-expiration
branch
from
f601843
to
90950a9
Compare
|
Docs for 90950a9 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2602/docs/artifacts/html/index.html |
mike-sul
force-pushed
the
fix-tuf-targets-expiration
branch
from
90950a9
to
1e46c0a
Compare
|
Docs for 1e46c0a are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2603/docs/artifacts/html/index.html |
kprosise
approved these changes
Feb 8, 2024
Comment on lines
51
to
52
| tuf | ||
| --- |
There was a problem hiding this comment.
Suggested change
| tuf | |
| --- | |
| ``tuf`` | |
| ------- |
It turned the current info on the TUF targets expiration configuration is not quite accurate. It suggests to use `<build-type>.params.TUF_TARGETS_EXPIRE` parameters which is rather an internal mechanism and should not be recommended for users. The proper way to set targets metadata default validity period is through the `tuf.targets_expire_after` parameter, this is the one that we should recommend to users. Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
fix-tuf-targets-expiration
branch
from
1e46c0a
to
4db231f
Compare
|
Docs for 4db231f are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2604/docs/artifacts/html/index.html |
angolini
approved these changes
Feb 8, 2024
vanmaegima
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned the current info on the TUF targets expiration configuration is not quite accurate. It suggests to use
<build-type>.params.TUF_TARGETS_EXPIREparameters which is rather an internal mechanism and should not be recommended for users.The proper way to set targets metadata default validity period is through the
tuf.targets_expire_afterparameter, this is the one that we should recommend to users.PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
make linkcheck.-s, --signoff).-S, --gpg-sign).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.